Skip to content

RowSelectionBehavior Implementation #10831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Conversation

tianzhao-stripe
Copy link
Contributor

@tianzhao-stripe tianzhao-stripe commented May 20, 2025

Summary

Made row selection callback available to app
Validate config
Once embeddedPaymentElement selection changes, invoke the internalRowSelectionCallback

Motivation

https://docs.google.com/document/d/1_LyLbnJV0KnHPp739xXUYAFr9bdjRvxp-Mh20Y2ZmWM/edit?tab=t.0
https://jira.corp.stripe.com/browse/MOBILESDK-3453

Testing

TODO

  • Added tests
  • Modified tests
  • Manually verified

Changelog

  • [ADDED]10831 Added RowSelectionBehavior API to Embedded Payment Element

Copy link
Contributor

github-actions bot commented May 20, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ -1 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ -1 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20669 │ 20669 │ 0 (+0 -0) 
   types │  6496 │  6496 │ 0 (+0 -0) 
 classes │  5261 │  5261 │ 0 (+0 -0) 
 methods │ 31499 │ 31499 │ 0 (+0 -0) 
  fields │ 18208 │ 18208 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.9 KiB │ -2 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 29.2 KiB │ +1 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 55.1 KiB │ -1 B │ 129.1 KiB │  0 B │ (total)

@tianzhao-stripe tianzhao-stripe changed the base branch from CustomCTA_V1 to master May 20, 2025 17:00
@tianzhao-stripe tianzhao-stripe marked this pull request as ready for review May 20, 2025 17:00
@tianzhao-stripe tianzhao-stripe requested review from a team as code owners May 20, 2025 17:00
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains no tests. Please ensure new functionality is matched with associated tests.

@tianzhao-stripe tianzhao-stripe changed the title CustomCTA Implementation RowSelectionBehavior Implementation May 20, 2025
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to do a few more things:

  • Add analytics for what value we have for rowSelectionBehavior
  • Add a better integration / mock network test for this behavior for at least the happy path of selecting a no form PM, formSheetAction=continue + clicking primary button on the form, selecting a saved PM from the manage screen

@tianzhao-stripe tianzhao-stripe force-pushed the CustomCTA_V1_Impl branch 2 times, most recently from 9e2f99d to 324db73 Compare June 3, 2025 16:13
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding this to the playground as a configuration option, but that can happen as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants