-
Notifications
You must be signed in to change notification settings - Fork 673
RowSelectionBehavior Implementation #10831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains no tests. Please ensure new functionality is matched with associated tests.
...in/java/com/stripe/android/paymentelement/embedded/content/PaymentOptionDisplayDataHolder.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentelement/embedded/manage/ManageNavigator.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt
Outdated
Show resolved
Hide resolved
20ab4bd
to
8b9fde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to do a few more things:
- Add analytics for what value we have for rowSelectionBehavior
- Add a better integration / mock network test for this behavior for at least the happy path of selecting a no form PM, formSheetAction=continue + clicking primary button on the form, selecting a saved PM from the manage screen
paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt
Outdated
Show resolved
Hide resolved
...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt
Outdated
Show resolved
Hide resolved
...com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...om/stripe/android/paymentelement/embedded/content/DefaultEmbeddedConfigurationHandlerTest.kt
Outdated
Show resolved
Hide resolved
.../java/com/stripe/android/paymentelement/embedded/content/DefaultEmbeddedSheetLauncherTest.kt
Outdated
Show resolved
Hide resolved
.../java/com/stripe/android/paymentelement/embedded/content/DefaultEmbeddedSheetLauncherTest.kt
Outdated
Show resolved
Hide resolved
...sheet/src/test/java/com/stripe/android/paymentelement/embedded/manage/ManageNavigatorTest.kt
Show resolved
Hide resolved
9e2f99d
to
324db73
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEvent.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElement.kt
Outdated
Show resolved
Hide resolved
...com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...t/src/androidTest/java/com/stripe/android/paymentelement/EmbeddedPaymentElementTestRunner.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth adding this to the playground as a configuration option, but that can happen as a follow up.
...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt
Outdated
Show resolved
Hide resolved
...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt
Outdated
Show resolved
Hide resolved
dc02afa
to
0ab7701
Compare
Summary
Made row selection callback available to app
Validate config
Once embeddedPaymentElement selection changes, invoke the internalRowSelectionCallback
Motivation
https://docs.google.com/document/d/1_LyLbnJV0KnHPp739xXUYAFr9bdjRvxp-Mh20Y2ZmWM/edit?tab=t.0
https://jira.corp.stripe.com/browse/MOBILESDK-3453
Testing
TODO
Changelog
RowSelectionBehavior
API to Embedded Payment Element