[Link in FlowController] Consumes backend linkSettings and removes client flag #10891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
force-pushed
the
carlosmuvi/remove-client-flag
branch
from
2928d2a to
632c077
Compare
|
Diffuse output: APKDEX |
carlosmuvi-stripe
force-pushed
the
carlosmuvi/remove-client-flag
branch
from
4873545 to
ef1f31a
Compare
Comment on lines
+5
to
+9
| /** | ||
| * Provider interface for Link feature settings and behaviors, handling | ||
| * the logic for determining when to show special Link UI elements or trigger automatic | ||
| * behaviors to enhance the Link payment experience. | ||
| */ |
There was a problem hiding this comment.
Initially missed this class and then created LinkProminenceFeatureProvider. Deleted the latter and added docs to LinkGate so this doesn't happen to others in the future.
tillh-stripe
reviewed
Jun 4, 2025
Comment on lines
+299
to
+319
| @Test | ||
| fun `showRuxInFlowController - true when useNativeLink is true and backend flag is false`() { | ||
| val gate = gate( | ||
| isLiveMode = true, | ||
| useAttestationEndpoints = true, | ||
| disableRuxInFlowController = false | ||
| ) | ||
|
|
||
| assertThat(gate.showRuxInFlowController).isTrue() | ||
| } | ||
|
|
||
| @Test | ||
| fun `showRuxInFlowController - false when livemode and useNativeLink and but backend flag is true`() { | ||
| val gate = gate( | ||
| isLiveMode = true, | ||
| useAttestationEndpoints = true, | ||
| disableRuxInFlowController = true | ||
| ) | ||
|
|
||
| assertThat(gate.showRuxInFlowController).isFalse() | ||
| } |
There was a problem hiding this comment.
These are identical to the first two, no?
| } | ||
|
|
||
| @Test | ||
| fun `showRuxInFlowController - returns false when useNativeLink is true but backend flag is true`() { |
There was a problem hiding this comment.
Suggested change
| fun `showRuxInFlowController - returns false when useNativeLink is true but backend flag is true`() { | |
| fun `showRuxInFlowController - returns false when useNativeLink is true but disableRuxInFlowController is true`() { |
| } | ||
|
|
||
| @Test | ||
| fun `showRuxInFlowController - false when useNativeLink is false regardless of backend flag`() { |
There was a problem hiding this comment.
Suggested change
| fun `showRuxInFlowController - false when useNativeLink is false regardless of backend flag`() { | |
| fun `showRuxInFlowController - false when useNativeLink is false regardless of disableRuxInFlowController`() { |
carlosmuvi-stripe
changed the title
linkSettings and removes client flag
carlosmuvi-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LinkProminenceFeatureProviderand usesLinkGateto provide the RUX in FlowController enablement.Motivation
Testing
Screenshots
Changelog