Skip to content

Allow text input inset changes for Payment Element #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

Summary

Allow text input inset changes for Payment Element

Motivation

Merchant ask to modify the text input insets for Payment Element.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Jun 2, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   2.1 MiB │   2.1 MiB │ +580 B │   4.3 MiB │   4.3 MiB │ +1.2 KiB 
     arsc │     1 MiB │     1 MiB │    0 B │     1 MiB │     1 MiB │      0 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │      0 B 
      res │ 302.9 KiB │ 302.9 KiB │    0 B │   457 KiB │   457 KiB │      0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │      0 B 
    asset │   7.7 KiB │   7.7 KiB │    0 B │   7.4 KiB │   7.4 KiB │      0 B 
    other │  95.7 KiB │  95.7 KiB │   +3 B │ 183.5 KiB │ 183.5 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │   9.8 MiB │   9.8 MiB │ +583 B │  21.8 MiB │  21.8 MiB │ +1.2 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 20663 │ 20667 │ +4 (+9 -5)   
   types │  6492 │  6493 │ +1 (+1 -0)   
 classes │  5258 │  5259 │ +1 (+1 -0)   
 methods │ 31487 │ 31491 │ +4 (+28 -24) 
  fields │ 18210 │ 18219 │ +9 (+62 -53) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK
    compressed     │    uncompressed     │                                
──────────┬────────┼──────────┬──────────┤                                
 size     │ diff   │ size     │ diff     │ path                           
──────────┼────────┼──────────┼──────────┼────────────────────────────────
  2.1 MiB │ +580 B │  4.3 MiB │ +1.2 KiB │ ∆ classes.dex                  
  6.8 KiB │   -4 B │  6.6 KiB │     -4 B │ ∆ assets/dexopt/baseline.prof  
    919 B │   +4 B │    787 B │     +4 B │ ∆ assets/dexopt/baseline.profm 
 29.2 KiB │   +4 B │ 64.6 KiB │      0 B │ ∆ META-INF/CERT.SF             
 25.9 KiB │   -2 B │ 64.5 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  1.2 KiB │   +1 B │  1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼────────┼──────────┼──────────┼────────────────────────────────
  2.1 MiB │ +583 B │  4.5 MiB │ +1.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   20663 │ 20667 │ +4 (+9 -5) 
  
  + , top=0.0, end=
  + FormInsets(start=
  + Lb4/g;
  + VLLLLLZZZLLLL
  + VLLLZLLLLZLLLLZIILLLLLI
  + VLLLZLLLZLLLLLLZZZL
  + VLZZLLLZZLZLLLLLLLLLI
  + paddingValues
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"7f56f4d","r8-mode":"full","version":"8.8.34"}
  
  - VLLLLLZZZLLL
  - VLLLZLLLLZLLLLZIILLLI
  - VLLLZLLLZLLLLLZZZL
  - VLZZLLLZZLZLLLLLLLI
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"01c9ac7","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6492 │ 6493 │ +1 (+1 -0) 
  
  + Lb4/g;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   31487 │ 31491 │ +4 (+28 -24) 
  
  + W3.i0 <init>(I, g, o2, s1, d)
  + Y0.c e(String, e, J, d, d, d, boolean, boolean, boolean, j, L, a, c0, p, int)
  + Y0.c f(A, c, o, boolean, J, d, d, d, boolean, String, J, i0, h0, boolean, int, int, j, a, c0, L, p, int)
  + b4.a <init>(float, float, float)
  + b4.b <init>(long, long, long, long, long, long, long, long, I)
  + b4.c equals(Object) → boolean
  + b4.c hashCode() → int
  + b4.c toString() → String
  + b4.f <clinit>()
  + b4.f a(int, p, boolean) → float
  + b4.f b(p) → b
  + b4.f c(p) → c
  + b4.f d(J) → J
  + b4.g <init>(int, int, int, float, long, long, long, long, long, long, Integer, m, m, m, m, m, m, m)
  + b4.g equals(Object) → boolean
  + b4.g hashCode() → int
  + b4.g toString() → String
  + e4.F0 <init>(A, boolean, boolean, String, String, C0, boolean, boolean, String, boolean, L, o, J, k, i0, h0, c, c, int)
  + e4.N0 <init>(A, c, o, boolean, String, String, C0, boolean, String, J, i0, h0, c0, L, boolean, boolean, boolean, c)
  + e4.P0 d(A, boolean, boolean, String, String, C0, boolean, boolean, String, boolean, L, o, J, k, i0, h0, c, c, p, int)
  + f4.b <init>(A, c, o, boolean, J, d, d, d, boolean, String, J, i0, h0, boolean, int, int, j, a, c0, L, int)
  + f4.c <init>(String, e, J, d, d, d, boolean, boolean, boolean, j, L, a, c0, int)
  + f4.h <init>(d, d, String, c0, boolean, boolean, j, d, a, e, boolean, L, boolean)
  + f4.j <init>(A, J, d, d, d, boolean, boolean, boolean, j, a, c0, L)
  + f4.m <init>(o, e, d, d, d, d, boolean, float, L, int)
  + f4.n a(o, e, d, d, d, d, boolean, float, L, p, int)
  + f4.n b(int, boolean, int, int, int, int, long, float, L) → int
  + f4.p <init>(boolean, float, L)
  
  - W3.i0 <init>(I, f, o2, s1, d)
  - Y0.c e(String, e, J, d, d, d, boolean, boolean, boolean, j, M, a, c0, p, int)
  - Y0.c f(A, c, o, boolean, J, d, d, d, boolean, String, J, i0, h0, boolean, int, int, j, a, c0, p, int)
  - b4.a <init>(long, long, long, long, long, long, long, long, I)
  - b4.c <clinit>()
  - b4.e a(int, p, boolean) → float
  - b4.e b(p) → a
  - b4.e c(p) → b
  - b4.e d(J) → J
  - b4.f <init>(int, int, int, float, long, long, long, long, long, long, Integer, m, m, m, m, m, m, m)
  - b4.f equals(Object) → boolean
  - b4.f hashCode() → int
  - b4.f toString() → String
  - e4.F0 <init>(A, boolean, boolean, String, String, C0, boolean, boolean, String, boolean, o, J, k, i0, h0, c, c, int)
  - e4.N0 <init>(A, c, o, boolean, String, String, C0, boolean, String, J, i0, h0, c0, boolean, boolean, boolean, c)
  - e4.P0 d(A, boolean, boolean, String, String, C0, boolean, boolean, String, boolean, o, J, k, i0, h0, c, c, p, int)
  - f4.b <init>(A, c, o, boolean, J, d, d, d, boolean, String, J, i0, h0, boolean, int, int, j, a, c0, int)
  - f4.c <init>(String, e, J, d, d, d, boolean, boolean, boolean, j, M, a, c0, int)
  - f4.h <init>(d, d, String, c0, boolean, boolean, j, d, a, e, boolean, M, boolean)
  - f4.j <init>(A, d, J, d, d, boolean, boolean, boolean, j, a, c0)
  - f4.m <init>(o, e, d, d, d, d, boolean, float, M, int)
  - f4.n a(o, e, d, d, d, d, boolean, float, M, p, int)
  - f4.n b(int, boolean, int, int, int, int, long, float, M) → int
  - f4.p <init>(boolean, float, M)
  

FIELDS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   18210 │ 18219 │ +9 (+62 -53) 
  
  + W3.i0 Q: g
  + b4.a a: float
  + b4.a b: float
  + b4.a c: float
  + b4.b a: long
  + b4.b b: long
  + b4.b c: long
  + b4.b d: long
  + b4.b e: long
  + b4.b f: long
  + b4.b g: long
  + b4.b h: long
  + b4.b i: I
  + b4.d a: b
  + b4.d b: c
  + b4.d c: g
  + b4.d d: a
  + b4.e a: b
  + b4.e b: b
  + b4.e c: c
  + b4.e d
...✂

@samer-stripe samer-stripe force-pushed the samer/allow-text-input-inset-changes branch from 1c31642 to 3d87e4e Compare June 9, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant