[Link OTP in WalletsButton] Resend code logic #10929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-otp-2-complete-verification # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/verification/DefaultLinkInlineInteractor.kt # paymentsheet/src/test/java/com/stripe/android/link/account/FakeLinkAccountManager.kt
carlosmuvi-stripe
changed the base branch from
master
to
carlosmuvi/embedded-otp-2-complete-verification
|
Diffuse output: APK |
carlosmuvi-stripe
force-pushed
the
carlosmuvi/embedded-otp-3-resend
branch
from
edd2759 to
8fe186a
Compare
Base automatically changed from
carlosmuvi/embedded-otp-2-complete-verification
to
master
June 9, 2025 16:12
…arlosmuvi/embedded-otp-3-resend # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/verification/DefaultLinkInlineInteractor.kt
…-otp-3-resend # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/verification/DefaultLinkInlineInteractor.kt # paymentsheet/src/test/java/com/stripe/android/link/verification/DefaultLinkInlineInteractorTest.kt
carlosmuvi-stripe
changed the title
Comment on lines
+40
to
+44
| override val useInlineOtpInWalletButtons: Boolean | ||
| get() { | ||
| return FeatureFlags.showInlineOtpInWalletButtons.isEnabled && useNativeLink | ||
| } | ||
|
|
There was a problem hiding this comment.
Using LinkGate to also avoid showing the inline 2FA on non-native-link scenarios.
Comment on lines
+68
to
+71
| OTPSection( | ||
| verificationState = verificationState, | ||
| otpElement = otpElement | ||
| ) |
There was a problem hiding this comment.
no new code, just extracted to method + added the resend code button.
Comment on lines
+140
to
+153
| private fun update2FAState( | ||
| block: (VerificationViewState) -> VerificationViewState, | ||
| ) { | ||
| val currentState = state.value.verificationState | ||
| if (currentState is Render2FA) { | ||
| val newState = currentState.copy(viewState = block(currentState.viewState)) | ||
| updateState { it.copy(verificationState = newState) } | ||
| } else { | ||
| logger.error( | ||
| "Expected Render2FA state but found ${currentState::class.simpleName}. Resetting to RenderButton." | ||
| ) | ||
| updateState { it.copy(verificationState = VerificationState.RenderButton) } | ||
| } | ||
| } |
There was a problem hiding this comment.
extracted this update logic to a method as it's reused on several places.
tillh-stripe
reviewed
Jun 9, 2025
paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/LinkInline2FASection.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/LinkInline2FASection.kt
Show resolved
Hide resolved
| val currentState = state.value.verificationState | ||
| if (currentState is Render2FA) { | ||
| val linkAccountManager = currentState.linkAccountManager() | ||
| val result = linkAccountManager.startVerification() |
There was a problem hiding this comment.
Should we show the loading indicator for a minimum amount of time, so that it's obvious that a new code is being sent?
There was a problem hiding this comment.
I think we should be good here:
- The loading shows while the verification API call takes place. We also show a toast when the verification completes.
- This is the pattern on other OTP instances
We can potentially ad a delay after startVerification to hold the state change a bit, but feels wrong.
Attached a video of how it looks today on a real device.
loading_2fa.mp4
| @@ -22,15 +28,18 @@ internal class WalletButtonsContent( | |||
| @Composable | |||
| fun Content() { | |||
| val state by interactor.state.collectAsState() | |||
| val context = LocalContext.current | |||
There was a problem hiding this comment.
Nit: Let's move this into ResendCodeNotificationEffect.
tillh-stripe
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
linkGateto enable inline OTP instead of directly checking the fflag.record_2fa_resend.mp4
Testing