Skip to content

Support custom h1 font modification #10930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Support custom h1 font modification #10930

merged 3 commits into from
Jun 10, 2025

Conversation

samer-stripe
Copy link
Collaborator

Summary

Support custom h1 font modification

Motivation

Merchant ask to manage headers within PaymentSheet

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   2.1 MiB │   2.1 MiB │ +69 B │   4.3 MiB │   4.3 MiB │ +184 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │    0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │    0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.7 KiB │   7.7 KiB │  +2 B │   7.4 KiB │   7.4 KiB │   +2 B 
    other │  95.7 KiB │  95.7 KiB │  +6 B │ 183.5 KiB │ 183.5 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │   9.8 MiB │   9.8 MiB │ +77 B │  21.8 MiB │  21.8 MiB │ +186 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 20663 │ 20662 │ -1 (+1 -2) 
   types │  6492 │  6492 │  0 (+0 -0) 
 classes │  5258 │  5258 │  0 (+0 -0) 
 methods │ 31487 │ 31487 │  0 (+1 -1) 
  fields │ 18210 │ 18210 │  0 (+1 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK
    compressed    │   uncompressed    │                               
──────────┬───────┼──────────┬────────┤                               
 size     │ diff  │ size     │ diff   │ path                          
──────────┼───────┼──────────┼────────┼───────────────────────────────
  2.1 MiB │ +69 B │  4.3 MiB │ +184 B │ ∆ classes.dex                 
 25.9 KiB │  +3 B │ 64.5 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
  6.8 KiB │  +2 B │  6.6 KiB │   +2 B │ ∆ assets/dexopt/baseline.prof 
 29.2 KiB │  +2 B │ 64.6 KiB │    0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │  +1 B │  1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
──────────┼───────┼──────────┼────────┼───────────────────────────────
  2.1 MiB │ +77 B │  4.5 MiB │ +186 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   20663 │ 20662 │ -1 (+1 -2) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"a84acbb","r8-mode":"full","version":"8.8.34"}
  
  - , h4FontFamily=
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"01c9ac7","r8-mode":"full","version":"8.8.34"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   31487 │ 31487 │ 0 (+1 -1) 
  
  + b4.f <init>(int, int, int, float, long, long, long, long, long, long, Integer, J, m, m, m, m, m, m)
  
  - b4.f <init>(int, int, int, float, long, long, long, long, long, long, Integer, m, m, m, m, m, m, m)
  

FIELDS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   18210 │ 18210 │ 0 (+1 -1) 
  
  + b4.f l: J
  
  - b4.f l: m

@samer-stripe samer-stripe marked this pull request as ready for review June 9, 2025 19:18
@samer-stripe samer-stripe requested review from a team as code owners June 9, 2025 19:18
@samer-stripe samer-stripe force-pushed the samer/custom-fonts branch 2 times, most recently from c1d3ab7 to bad7973 Compare June 10, 2025 15:17
@samer-stripe samer-stripe merged commit cfa4121 into master Jun 10, 2025
13 checks passed
@samer-stripe samer-stripe deleted the samer/custom-fonts branch June 10, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants