Improve pane transitions in bank auth flow

[tillh-stripe]

Summary

This pull request adds proper pane slide transitions in the bank auth flow, and a fade effect for the Stripe logo in the top bar.

We exclude the attach-payment screen from the slide transitions, as it would just cause a slide from one loading indicator to another (we use a fade instead).

Motivation

Testing

• Added tests
• Modified tests
• Manually verified

Screen recordings

Before

before.mp4

After

after.mp4

Changelog

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │     7 KiB │     7 KiB │  0 B │   6.8 KiB │   6.8 KiB │  0 B 
    other │  85.4 KiB │  85.5 KiB │ +7 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +7 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20108 │ 20108 │ 0 (+0 -0) 
   types │  6205 │  6205 │ 0 (+0 -0) 
 classes │  4991 │  4991 │ 0 (+0 -0) 
 methods │ 30124 │ 30124 │ 0 (+0 -0) 
  fields │ 17572 │ 17572 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0

APK

   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 28.3 KiB │ +6 B │ 62.6 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 29.5 KiB │ +7 B │ 63.8 KiB │  0 B │ (total)

[malecks-stripe]

Looking good! I noticed in the 'after' that the bank logos load simultaneously, vs. the 'before' where a few logos loaded first and then the rest loaded afterward. Is that a change related to this PR? Or just happened to be the case during the recording?

[tillh-stripe]

@malecks-stripe That’s likely because of caching from the previous run. We kick off the request for all bank logos at the same time, so any delays would be random.

[carlosmuvi-stripe]

lmk what you think, but I prefer being more declarative with checks like this by just adding a new field on the Destination class. Happy to be convinced otherwise!

[carlosmuvi-stripe]

This definitely improves the current experience!