Skip to content

Reduce IntegrationTester flake #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Reduce IntegrationTester flake #4657

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1007733
Reduce flake
davidme-stripe Mar 11, 2025
9520a2b
Reduce flake
davidme-stripe Mar 11, 2025
8752bee
Reduce flake
davidme-stripe Mar 12, 2025
3715a77
Don't fix sim
davidme-stripe Mar 14, 2025
6f621ee
Merge branch 'master' into davidme/reduce-flake
davidme-stripe Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions Testers/IntegrationTester/IntegrationTesterUITests/IntegrationTesterUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,17 @@ class IntegrationTesterUICardTests: IntegrationTesterUITests {
func testSingleSelect3DS2() throws {
testSingleSelectAuthentication(cardNumber: alwaysSingleSelectCard)
}

let alwaysMultiSelectCard = "4000582600000110"
func testMultiSelect3DS2() throws {
testMultiSelectAuthentication(cardNumber: alwaysMultiSelectCard)
}

let hsbcCard = "4000582600000292"
func testHSBCHTMLIssue() throws {
testHSBCWebViewLinksTrigger(cardNumber: hsbcCard)
}

let browserFallbackCard = "4000582600000060"
func testBrowserFallback() throws {
testBrowserFallbackAuthentication(cardNumber: browserFallbackCard)
Expand Down Expand Up @@ -324,7 +324,7 @@ class IntegrationTesterUITests: XCTestCase {
XCTAssertTrue(statusView.waitForExistence(timeout: 10.0))
XCTAssertNotNil(statusView.label.range(of: expectedResult))
}

func testHSBCWebViewLinksTrigger(cardNumber: String) {
print("Testing \(cardNumber)")

Expand All @@ -334,11 +334,11 @@ class IntegrationTesterUITests: XCTestCase {
let cardExampleElement = tablesQuery.cells.buttons["Card"]
cardExampleElement.tap()
try! fillCardData(app, number: cardNumber)

let buyButton = app.buttons["Buy"]
XCTAssertTrue(buyButton.waitForExistence(timeout: 60.0))
buyButton.forceTapElement()

let oobChallengeScreenPredicate = NSPredicate(format: "label ==[c] 'OTP'")
let challengeText = app.staticTexts.matching(oobChallengeScreenPredicate).element
XCTAssertTrue(challengeText.waitForExistence(timeout: 10))
Expand All @@ -347,21 +347,21 @@ class IntegrationTesterUITests: XCTestCase {
let submitButton = app.buttons["Submit"]
XCTAssertTrue(submitButton.waitForExistence(timeout: 10.0))
submitButton.forceTapElement()

let enterCodePredicate = NSPredicate(format: "placeholderValue CONTAINS[c] 'Enter OTP here'")
let enterCodeText = app.textFields.matching(enterCodePredicate).element
XCTAssertTrue(enterCodeText.waitForExistence(timeout: 10))
enterCodeText.tap()
enterCodeText.typeText("555555")

let doneButton = app.buttons["Done"]
XCTAssertTrue(doneButton.waitForExistence(timeout: 10.0))
doneButton.forceTapElement()

let submitCodeButton = app.buttons["Submit"]
XCTAssertTrue(submitCodeButton.waitForExistence(timeout: 10.0))
submitCodeButton.forceTapElement()

let statusView = app.staticTexts["Payment status view"]
XCTAssertTrue(statusView.waitForExistence(timeout: 10.0))
XCTAssertNotNil(statusView.label.range(of: "Payment complete!"))
Expand Down Expand Up @@ -449,7 +449,7 @@ class IntegrationTesterUITests: XCTestCase {
XCTAssertTrue(statusView.waitForExistence(timeout: 10.0))
XCTAssertNotNil(statusView.label.range(of: "Payment complete!"))
}

func testMultiSelectAuthentication(cardNumber: String) {
print("Testing \(cardNumber)")
self.popToMainMenu()
Expand All @@ -466,11 +466,11 @@ class IntegrationTesterUITests: XCTestCase {
let challengeScreenPredicate = NSPredicate(format: "label CONTAINS[c] 'This is a test 3D Secure 2 authentication for a transaction, showing a sample multi-select flow. In live mode, customers may be asked to answer a security question.'")
let challengeText = app.staticTexts.matching(challengeScreenPredicate).element
XCTAssertTrue(challengeText.waitForExistence(timeout: 10))

for button in app.buttons.matching(identifier: "Complete Authentication").allElementsBoundByIndex {
button.tap()
}

let completeAuth = app.scrollViews.otherElements.staticTexts["Submit"]
XCTAssertTrue(completeAuth.waitForExistence(timeout: 60.0))
completeAuth.tap()
Expand All @@ -479,7 +479,7 @@ class IntegrationTesterUITests: XCTestCase {
XCTAssertTrue(statusView.waitForExistence(timeout: 10.0))
XCTAssertNotNil(statusView.label.range(of: "Payment complete!"))
}

func testBrowserFallbackAuthentication(cardNumber: String) {
print("Testing \(cardNumber)")
self.popToMainMenu()
Expand All @@ -492,11 +492,11 @@ class IntegrationTesterUITests: XCTestCase {
let buyButton = app.buttons["Buy"]
XCTAssertTrue(buyButton.waitForExistence(timeout: 30.0))
buyButton.forceTapElement()

let completeButton = app.buttons["COMPLETE"]
XCTAssertTrue(completeButton.waitForExistence(timeout: 30.0))
completeButton.forceTapElement()

let statusView = app.staticTexts["Payment status view"]
XCTAssertTrue(statusView.waitForExistence(timeout: 10.0))
XCTAssertNotNil(statusView.label.range(of: "Payment complete!"))
Expand Down Expand Up @@ -546,7 +546,7 @@ class IntegrationTesterUITests: XCTestCase {
buyButton.forceTapElement()

let safari = XCUIApplication(bundleIdentifier: "com.apple.mobilesafari")
XCTAssertTrue(safari.wait(for: .runningForeground, timeout: 10)) // wait for Safari to open
XCTAssertTrue(safari.wait(for: .runningForeground, timeout: 30)) // wait for Safari to open, may take a while the first time
let webViewsQuery = safari.webViews
// Sometimes this is a Button, sometimes it's a StaticText. ¯\_(ツ)_/¯
let completeAuth = webViewsQuery.descendants(matching: .any)["AUTHORIZE TEST PAYMENT"].firstMatch
Expand Down
Loading