Support BDCC in native Link #4692
Conversation
tillh-stripe
force-pushed
the
tillh/link-bdcc
branch
from
0d6c288 to
8cc39bc
Compare
|
🚨 New dead code detected in this PR: ConsumerSession.swift:24 warning: Initializer 'init(clientSecret:emailAddress:redactedFormattedPhoneNumber:unredactedPhoneNumber:phoneNumberCountry:verificationSessions:supportedPaymentDetailsTypes:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
| @@ -16,19 +16,25 @@ final class ConsumerSession: Decodable { | |||
| let clientSecret: String | |||
| let emailAddress: String | |||
| let redactedFormattedPhoneNumber: String | |||
| let unredactedPhoneNumber: String? | |||
There was a problem hiding this comment.
We're pulling the unredacted phone number to potentially prefill an empty phone number field.
tillh-stripe
force-pushed
the
tillh/link-bdcc
branch
10 times, most recently
from
051eb11 to
b3f9d9e
Compare
tillh-stripe
force-pushed
the
tillh/link-bdcc
branch
2 times, most recently
from
9ba4d76 to
c73ccd6
Compare
tillh-stripe
force-pushed
the
tillh/link-bdcc
branch
from
c73ccd6 to
8395c6f
Compare
| @@ -385,8 +389,10 @@ extension STPAPIClient { | |||
| ] | |||
|
|
|||
| if let details = updateParams.details, case .card(let expiryDate, let billingDetails) = details { | |||
| parameters["exp_month"] = expiryDate.month | |||
| parameters["exp_year"] = expiryDate.year | |||
| if let expiryDate { | |||
There was a problem hiding this comment.
Does the update call work if expiryDate is nil?
| let label = UILabel() | ||
| label.font = LinkUI.font(forTextStyle: .title) | ||
| label.textColor = .linkPrimaryText | ||
| label.adjustsFontForContentSizeCategory = true | ||
| label.numberOfLines = 0 | ||
| label.textAlignment = .center | ||
| label.text = String.Localized.update_card | ||
| label.text = if isBillingDetailsUpdateFlow { | ||
| // TODO: Localize me |
There was a problem hiding this comment.
Can you make this a localized string before landing?
| private lazy var cvcElement: TextFieldElement = { | ||
| let cvcElement = TextFieldElement( | ||
| configuration: TextFieldElement.CVCConfiguration( | ||
| // If we're using a placeholder, we just fill up the view with zeros. |
There was a problem hiding this comment.
We'll render it as "•••" though, right?
There was a problem hiding this comment.
Ah, yes, I see that below now
There was a problem hiding this comment.
Yep, but with this ugly workaround 😕 I just noticed that CensoredCVCConfiguration exists, which gives us that functionality for free, but it makes the look different from the other disabled fields. What do you think about this?
| private extension STPElementsSession { | ||
| func isCompatible(with configuration: PaymentElementConfiguration) -> Bool { | ||
| // We can't collect billing details if we're in the web flow, so turn Link off for those cases. | ||
| let nativeLink = deviceCanUseNativeLink(elementsSession: self, configuration: configuration) |
There was a problem hiding this comment.
Kinda wondering what happens if the device fails the attestation check after this — I almost wonder if we should just hide Link entirely if attestation fails instead of falling back to the web flow.
Summary
Motivation
Testing
Changelog