Skip to content

Add initial version of a standalone Link component #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Jul 7, 2025

Summary

This pull request adds an initial version of a standalone Link component. Lots of things aren't final yet, but opening it for review now so that dependent work is unblocked.

Motivation

Testing

Changelog

@tillh-stripe tillh-stripe force-pushed the tillh/link-standalone-component branch from bccbdc6 to 9a9468c Compare July 7, 2025 13:47
Copy link

github-actions bot commented Jul 7, 2025

⚠️ Public API changes detected:

StripePaymentSheet

- public var emailAddress: Swift.String? {
+ get
+ set
+ }
- public var legalName: Swift.String? {
+ get
+ set
+ }
- public var phone: Swift.String? {
+ get
+ }
+ @objc deinit

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Copy link

github-actions bot commented Jul 7, 2025

🚨 New dead code detected in this PR:

LinkController.swift:46 warning: Property 'mode' is assigned, but never used

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe requested a review from mats-stripe July 7, 2025 15:36
@tillh-stripe tillh-stripe marked this pull request as ready for review July 7, 2025 15:36
@tillh-stripe tillh-stripe requested review from a team as code owners July 7, 2025 15:36
@tillh-stripe tillh-stripe requested review from porter-stripe and removed request for porter-stripe July 7, 2025 15:36
@tillh-stripe tillh-stripe marked this pull request as draft July 7, 2025 15:36
@tillh-stripe tillh-stripe force-pushed the tillh/link-standalone-component branch from 3b195d4 to d92d38d Compare July 7, 2025 15:37
@tillh-stripe tillh-stripe marked this pull request as ready for review July 7, 2025 19:22
@tillh-stripe tillh-stripe marked this pull request as draft July 7, 2025 19:28
@tillh-stripe tillh-stripe force-pushed the tillh/link-standalone-component branch from d92d38d to 3c4e6c3 Compare July 7, 2025 19:39
@tillh-stripe tillh-stripe marked this pull request as ready for review July 7, 2025 22:02
@mats-stripe mats-stripe merged commit 1812b26 into master Jul 9, 2025
6 checks passed
@mats-stripe mats-stripe deleted the tillh/link-standalone-component branch July 9, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants