Scale error fonts in payment sheet #5125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceqin-stripe
approved these changes
Jul 9, 2025
| @@ -1081,6 +1081,8 @@ extension PaymentSheet.Appearance { | |||
| fonts.sectionHeader = scaledFont(for: font.base.medium, style: .footnote, maximumPointSize: 18) | |||
| fonts.caption = scaledFont(for: font.base.regular, style: .caption1, maximumPointSize: 20) | |||
| fonts.footnote = scaledFont(for: font.base.regular, style: .footnote, maximumPointSize: 20) | |||
| fonts.error = scaledFont(for: font.base.regular, style: .caption2, maximumPointSize: 20) | |||
| fonts.smallFootnote = scaledFont(for: font.base.medium, style: .caption2, maximumPointSize: 18) | |||
There was a problem hiding this comment.
Is there anywhere in particular the maximumPointSizes came from? Non-blocking and they seem like reasonable values but just wondering
There was a problem hiding this comment.
I was unable to find a definitive source for these numbers but decided to keep them in line with the rest of the UI
gbirch-stripe
deleted the
gbirch/scale-card-format-error-RUN_MOBILESDK-4439
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Payment sheet error and "smallFootnote" text changed to conform to Appearance API font settings (base font, scale).
Motivation
Testing
Updated snapshot tests which already over this case
Changelog
[Fixed] Form error text not respecting Appearance API font settings