WalletButtonsView: Fix Link in passthrough mode #5126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring - Link now appears as the first wallet option when PaymentSheet.isLinkEnabled is true - Ignores Link's position in orderedPaymentMethodTypesAndWallets to ensure consistent UX - Preserves existing Link inline verification logic - Other wallets maintain their server-specified ordering 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
davidme-stripe
requested review from
tillh-stripe
and removed request for
joyceqin-stripe
davidme-stripe
changed the title
tillh-stripe
previously approved these changes
Jul 8, 2025
- Fixed test expectations to reflect Link appearing first when enabled - Added new test cases for Link priority behavior - Added test to verify Link is not shown when disabled - Updated ShopPay configuration syntax in tests
tillh-stripe
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Link now appears as the first wallet option when PaymentSheet.isLinkEnabled is true, enabling it in PM mode and passthrough mode
Test plan
🤖 Generated with Claude Code