Skip to content

Default state dropdown to empty #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 10, 2025
Merged

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Jul 8, 2025

Summary

  • Instead of the "State" dropdown defaulting to selecting the first in the list (Alabama) we now default to no selection so users are forced to select a state to prevent accidental completions without selecting a state.
  • Applies to Address Element and PaymentSheet
    Simulator Screenshot - iOS 18  - 2025-07-09 at 13 20 31

Motivation

🌲

Testing

  • Manual
  • New tests
  • Updated existing tests

Changelog

N/A

Copy link

github-actions bot commented Jul 8, 2025

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Selection is empty.

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@porter-stripe porter-stripe marked this pull request as ready for review July 10, 2025 00:07
@porter-stripe porter-stripe requested review from a team as code owners July 10, 2025 00:07
@porter-stripe porter-stripe enabled auto-merge (squash) July 10, 2025 00:07
@porter-stripe porter-stripe merged commit 9464e83 into master Jul 10, 2025
7 checks passed
@porter-stripe porter-stripe deleted the porter/default-state-empty branch July 10, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants