Use Link branding for PTM payment methods in SPM #5130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
commented
Jul 8, 2025
| @@ -59,6 +59,8 @@ struct ElementsCustomer: Equatable, Hashable { | |||
| let paymentMethod = paymentMethodWithLinkDetails.paymentMethod | |||
| if let linkDetails = paymentMethodWithLinkDetails.linkDetails { | |||
| paymentMethod.setLinkPaymentDetails(from: linkDetails) | |||
| } else { | |||
| paymentMethod.isLinkPassthroughMode = paymentMethodWithLinkDetails.isLinkOrigin | |||
There was a problem hiding this comment.
A payment method is only created in Link passthrough if isLinkOrigin is true but linkDetails is nil.
tillh-stripe
commented
Jul 8, 2025
| @@ -779,7 +779,7 @@ extension PaymentOption { | |||
| let hasLinkAccount = LinkAccountContext.shared.account?.isRegistered ?? false | |||
| switch self { | |||
| case .saved(let paymentMethod, _): | |||
| return paymentMethod.isLinkPaymentMethod && hasLinkAccount | |||
| return (paymentMethod.isLinkPaymentMethod || paymentMethod.isLinkPassthroughMode) && hasLinkAccount | |||
There was a problem hiding this comment.
Treat passthrough and payment method mode the same when it comes to the return-user experience.
davidme-stripe
previously approved these changes
Jul 8, 2025
davidme-stripe
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request extends the Link branding beyond payment methods of type
linkto payment methods that were created in passthrough mode.Motivation
Testing
Changelog