Add intrinsicContentSize to CardFormView to allow presentation in SwiftUI to work properly #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StripePaymentsUI- public var intrinsicContentSize: CoreFoundation.CGSize {
+ @objc get
+ }If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
wooj-stripe
changed the title
wooj-stripe
force-pushed
the
wooj/cardFormViewPriorityViewSwiftUI
branch
3 times, most recently
from
2812b78 to
a737c9e
Compare
wooj-stripe
force-pushed
the
wooj/cardFormViewPriorityViewSwiftUI
branch
from
a737c9e to
3ed5ccf
Compare
wooj-stripe
requested review from
davidme-stripe,
porter-stripe and
gbirch-stripe
and removed request for
davidme-stripe
| @@ -65,6 +65,22 @@ public class STPFormView: UIView, STPFormInputValidationObserver { | |||
| static let cornerRadius: CGFloat = 6 | |||
| static let interSectionSpacing: CGFloat = 7 | |||
|
|
|||
| public override var intrinsicContentSize: CGSize { | |||
There was a problem hiding this comment.
Any reason we can't just override this in the STPCardFormView.Representable? I think overriding this where we us constraints and intrinsicContentSize may not be correct but not sure.
porter-stripe
approved these changes
Jul 11, 2025
wooj-stripe
added a commit
that referenced
this pull request
Jul 11, 2025
## Summary This is a much better approach than: #5134 ## Motivation CardFormView basically shrinks down to nothing if surrounded by high priority views. ## Testing Relying on existing screenshot tests and manual testing ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SwiftUI is having trouble rendering this view when surrounded by high priority views. To remedy, returning the intrinsic content size seems to remedy this. Not ideal as having to manually calculate it is difficult. If there are other approaches I'm open to it, but given we only had to re-record a single snapshot test, i'm okay moving forward with this solution.
Motivation
Surrounding the view with high priority views was breaking this view in swift UI
Testing
Existing tests in:
Manually tested by using the UI Examples app and testing w/ surrounding between two high priority views.
Changelog