Skip to content

Revert "Continually attempt to presentshopPay as a workaround" and adds different fix #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

wooj-stripe
Copy link
Collaborator

Summary

  • Reverts workaround which continually taps (in one commit)
  • Adds a different workaround to tap the button
  • Defaults shopid to test shopid

Motivation

Less hacky workaround

Testing

Manually tested

Changelog

@wooj-stripe wooj-stripe marked this pull request as ready for review July 9, 2025 18:17
@wooj-stripe wooj-stripe requested review from a team as code owners July 9, 2025 18:17
@wooj-stripe wooj-stripe changed the title Wooj/shoppayclientfix Revert "Continually attempt to presentshopPay as a workaround" and adds different fix Jul 9, 2025
@wooj-stripe wooj-stripe requested review from toluo-stripe and removed request for gbirch-stripe July 9, 2025 18:19
@wooj-stripe wooj-stripe merged commit 58fbcc1 into master Jul 9, 2025
6 checks passed
@wooj-stripe wooj-stripe deleted the wooj/shoppayclientfix branch July 9, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants