Skip to content

Expand postal code validation #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gbirch-stripe
Copy link
Contributor

Summary

Add length validation for CA and GB, add regex format validation for US, CA, and GB, add more error messages.

Motivation

Testing

  • updated unit tests

Changelog

[Added] Postal code validation for Canada and UK addresses

Copy link

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Your ZIP code is invalid.

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant