Extract Link signup controller from PayWithLinkViewController #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
force-pushed
the
mats/extract_link_signup_controller
branch
from
6f3fe20 to
b57dc33
Compare
|
🚨 New dead code detected in this PR: PayWithLinkViewController-SignUpViewController.swift:86 warning: Parameter 'controller' is unused
PayWithLinkViewController-SignUpViewController.swift:77 warning: Parameter 'error' is unused
PayWithLinkViewController-SignUpViewController.swift:82 warning: Function 'signUpControllerDidCancel(_:)' is unused
LinkSignUpViewController.swift:25 warning: Parameter 'controller' is unused
LinkSignUpViewController.swift:22 warning: Parameter 'error' is unused
LinkSignUpViewController.swift:24 warning: Function 'signUpControllerDidCancel(_:)' is unused
LinkSignUpViewController.swift:252 warning: Parameter 'sender' is unused
LinkSignUpViewController.swift:289 warning: Parameter 'viewModel' is unused
LinkSignUpViewController.swift:360 warning: Parameter 'legalTermsView' is unused
LinkSignUpViewModel.swift:20 warning: Parameter 'viewModel' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mats-stripe
force-pushed
the
mats/extract_link_signup_controller
branch
from
2ae9cfa to
d97e7ee
Compare
mats-stripe
force-pushed
the
mats/extract_link_signup_controller
branch
from
d3ce680 to
5f7bc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to support a standalone Link authentication flow, we need to extract the SignUpViewController / ViewModel out of
PayWithLinkViewController. ThePayWithLinkViewController.SignUpViewControllerstill exists, it just uses the extractedLinkSignUpViewControllernow.In the next PR, I'll be adding support for a standalone Link authentication flow, which makes use of this
LinkSignUpViewController.Motivation
Standalone Link Auth
Testing
Sign up flow still works:
Screen.Recording.2025-07-10.at.9.18.08.AM.mov
Changelog
N/a