Skip to content

Adds New Module Structure for StripeCryptoOnramp #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 14, 2025

Conversation

mliberatore
Copy link
Collaborator

@mliberatore mliberatore commented Jul 10, 2025

Summary

Introduces a new module that will contain Crypto Onramp functionality documented at this internal tech spec.

Motivation

Please see the tech spec linked above and the links within for more information about the project. The motivation for this PR in particular is to start adding the module structure so we can begin the implementation work. We’ll likely eventually add an example app target to exercise new SDK functionality.

Testing

  1. Ensured that the project built and the placeholder test passed from within the new Xcode project.
  2. Ensured that the project built and the placeholder test passed when selecting the StripeCryptoOnramp target from within the Workspace.
  3. Compared the overall structure of the project to other SDKs in the workspace, ensuring we're following patterns and utilizing the appropriate build configurations.
CleanShot 2025-07-10 at 12 29 09 CleanShot 2025-07-10 at 12 29 25

Changelog

N/A as the SDK has not yet been implemented, so nothing was added that is usable by clients.

@mliberatore mliberatore requested a review from mats-stripe July 10, 2025 15:04
@mliberatore mliberatore requested review from a team as code owners July 10, 2025 15:04
@mliberatore mliberatore changed the title Adds New Module Structure for StripeOnramp Adds New Module Structure for StripeCryptoOnramp Jul 10, 2025
From CI:

Checking for SPM warnings...
Package.swift contains warnings:
warning: 'git': Invalid Exclude '/Users/vagrant/git/StripeCryptoOnramp/StripeCryptoOnramp/Info.plist': File not found.
… does not create new plist files for projects
Warning: DEFINES_MODULE was set, but no umbrella header could be found to generate the module map
@mliberatore mliberatore requested review from mats-stripe and removed request for mats-stripe July 10, 2025 20:27
@mliberatore mliberatore merged commit 31745d5 into master Jul 14, 2025
6 checks passed
@mliberatore mliberatore deleted the mliberatore/crypto-onramp-module-structure branch July 14, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants