[Feature] Make the lifecycle methods async ⚠️ #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #502 +/- ##
===========================================
- Coverage 97.09% 97.06% -0.04%
===========================================
Files 114 114
Lines 4137 4155 +18
Branches 1079 1082 +3
===========================================
+ Hits 4017 4033 +16
- Misses 120 122 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
titouanmathis
force-pushed
the
feature/async-lifecycle
branch
from
55e644a to
73d8446
Compare
titouanmathis
changed the title
titouanmathis
force-pushed
the
feature/async-lifecycle
branch
from
73d8446 to
1e5100c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No issue.
❓ Type of change
📚 Description
This PR makes the
$mount,$update,$destroyand$terminatemethod async. With the introduction of the non-blocking queue in #427, making these methods async will help us wait or not for the end of the different lifecycle action.📝 Checklist