-
Notifications
You must be signed in to change notification settings - Fork 3
[Feature] Use the existing domScheduler
for the withScrolledInView
decorator
#608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
titouanmathis
merged 3 commits into
develop
from
feature/with-scrolled-in-view-dom-scheduler
May 9, 2025
Merged
[Feature] Use the existing domScheduler
for the withScrolledInView
decorator
#608
titouanmathis
merged 3 commits into
develop
from
feature/with-scrolled-in-view-dom-scheduler
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## develop #608 +/- ##
===========================================
+ Coverage 99.01% 99.13% +0.11%
===========================================
Files 122 122
Lines 4183 4182 -1
Branches 1139 1140 +1
===========================================
+ Hits 4142 4146 +4
+ Misses 41 36 -5
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
79c87ac
to
c7fa947
Compare
c7fa947
to
0066944
Compare
0066944
to
3856073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fix: #607
β Type of change
π Description
This PR refactors the
withScrolledInView
decorator to reuse the existingdomScheluder
scheduler instead of a custom one.π Checklist