Skip to content

PHPStan Level 1#215

Merged
JJJ merged 4 commits intostuttter:masterfrom
lloc:chore/phpstan-level-1
Feb 25, 2025
Merged

PHPStan Level 1#215
JJJ merged 4 commits intostuttter:masterfrom
lloc:chore/phpstan-level-1

Conversation

@lloc
Copy link
Contributor

@lloc lloc commented Feb 10, 2025

Setting PHPStan to level 1 revealed three minor issues, which have been addressed in this PR:

  • Ignored the warning: "Constant WP_CONTENT_URL not found."
  • Fixed: "Variable $slug in empty() always exists and is not falsy." ( array_filter has been applied before.)
  • Fixed: "Variable $rows might not be defined."

@lloc
Copy link
Contributor Author

lloc commented Feb 24, 2025

@JJJ @spacedmonkey Do you think we can get those changes in? I would like to go ahead and raise the level. ;-)

@JJJ JJJ merged commit d32478f into stuttter:master Feb 25, 2025
1 check passed
thefrosty added a commit to thefrosty/wp-multi-network that referenced this pull request Dec 3, 2025
* master:
  PHPStan Level 6 (stuttter#221)
  PHPStan Level 5 (stuttter#220)
  Update README.md
  PHPStan Level 4 Compliance (stuttter#219)
  PHPStan Level 3 (stuttter#218)
  PHPStan Level 2 (stuttter#217)
  PHPStan Level 1 (stuttter#215)

# Conflicts:
#	wp-multi-network/includes/classes/class-wp-ms-networks-admin.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants