Allow to define default network bridge and xen-script #24
Conversation
README.md
Outdated
| | `xen_vman_default_auto_install` | boolean | `True` | Install specified OS automatically, when no xen configuration is found | | ||
| | Name | Type | : Required : | Default | Description | | ||
| |------------------------------------------|-----------------------|:-----------------------------:|---------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `xen_vman_xl_path` | string | N | _auto determined_ | Fully qualified path of the xl command | |
There was a problem hiding this comment.
Please consider using one column for Required/Default like in the roles written by @dasJ, @Scriptkiddi and me. I can't force you, but I want to appeal to you and would really like to see it.
I think it's a cleaner way of structuring the variable table, it saves space, gives a better overview and doesn't use too many columns. Besides, in almost all cases, a variable having a default value and a variable not being required occur together, so having two columns for this information is redundant and can be confusing.
| @@ -0,0 +1,16 @@ | |||
| --- | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This was even my first thought ;). But than I realized that xen-setup does a basic hypervisor setup for xen, such things like installing xen, configure grub on a debian based system. xen_vman instead does everything vm management related, such as creating, installing and manage all vms. Creating a proper xl.conf is needed for the tasks done by xen_vman, so it belongs there.
Future more, you can use xen-setup completely unrelated to the tasks done by xen_vman this way. For example you can setup a hypervisor with xen-setup and later use virtsh to manage all vms on this machine, which will conflict with a xl.conf managed by xen-setup.
|
Please rereview |
Mr-Pi
force-pushed
the
xl_conf
branch
4 times, most recently
from
f508eb6
to
6e97974
Compare
This will close #22