Add cache hit outputs #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beninato8
commented
Jun 13, 2025
Comment on lines
-366
to
+404
| [Alif Rachmawadi]: https://github.com/subosito | ||
| [Bartek Pacia]: https://github.com/bartekpacia | ||
| [Alif Rachmawadi](https://github.com/subosito) | ||
| [Bartek Pacia](https://github.com/bartekpacia) |
Contributor
Author
There was a problem hiding this comment.
these lines did not show up in the README, so i changed to links that do show up
Collaborator
There was a problem hiding this comment.
well, they were actually supposed to not show up. they are link reference definitions.
see https://github.github.com/gfm/#link-reference-definitions
Contributor
Author
There was a problem hiding this comment.
oops, my bad 😅. thanks for explaining!
bartekpacia
approved these changes
Jun 23, 2025
Collaborator
bartekpacia
left a comment
bartekpacia
left a comment
There was a problem hiding this comment.
LGTM, thank you! just some tiny changes and it's ready to be merged
README.md
Outdated
Comment on lines
322
to
325
| Note: `PUB-CACHE-HIT` and `CACHE-HIT` directly use the `cache-hit` output from `actions/cache@v4`, which is the following: | ||
| > - `cache-hit` - A string value to indicate an exact match was found for the key. | ||
| > - If there's a cache hit, this will be 'true' or 'false' to indicate if there's an exact match for `key`. | ||
| > - If there's a cache miss, this will be an empty string. |
Collaborator
There was a problem hiding this comment.
Please use this syntax to make it look nicer :)
README.md
Outdated
| > - If there's a cache hit, this will be 'true' or 'false' to indicate if there's an exact match for `key`. | ||
| > - If there's a cache miss, this will be an empty string. | ||
|
|
||
| Example usage (inspired by [actions/cache@v4](https://github.com/actions/cache?tab=readme-ov-file#skipping-steps-based-on-cache-hit) and [#346](https://github.com/subosito/flutter-action/pull/346)) to skip `melos bootstrap` if there was a pub cache hit: |
Collaborator
There was a problem hiding this comment.
pin the link to a specific commit so the link doesn't become broken in the future
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes requested in #346 from earlier this year, as I also would like to be able to use this feature.
It adds 2 new outputs: CACHE-HIT and PUB-CACHE-HIT. These just pass along the
cache-hitoutput fromactions/cache@v4for thecache-flutterandcache-pubsteps. These can be used for increasing workflow efficiency through steps like conditionally installing dependencies when the cache is invalid. The README is also updated with example usage to skipmelos bootstrapifPUB-CACHE-HITwas nottrue.I tested the outputs here: https://github.com/beninato8-forks/flutter-action/actions/runs/15627281250/job/44023816175
Output from the following steps (after a previous run was cached):
This PR closes #346