Skip to content

fix: allow to use blake3 to hash PV #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 17, 2025
Merged

fix: allow to use blake3 to hash PV #2236

merged 11 commits into from
Apr 17, 2025

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Apr 11, 2025

Motivation

verify() fails on proofs when sp1-zkvm blake3 feature is enabled.

Solution

Remove the blake3 feature everywhere except in sp1-zkvm, and when we want to verify PV, check with both Sha256 and Blake3 hashing.

@leruaa leruaa force-pushed the aurelien/hash-pv-with-blake3 branch from 1917583 to 0fb977d Compare April 15, 2025 10:54
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more documentation about the cross-collision infeasibility + use a helper function to increase code re-use.

In sp1-verifier we should also make it such that it checks both, rather than requiring a feature flag.

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on functions that can be cleaned up. Can you also clean up the PR description?

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for how to polish the documentation to be more readable.

Once addressed, will approve.

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leruaa leruaa merged commit 613acca into dev Apr 17, 2025
11 checks passed
@leruaa leruaa deleted the aurelien/hash-pv-with-blake3 branch April 17, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants