🔧(docker) add a service in compose to frontend development #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want a serice in compose starting the frontend application in development mode. We want to take the advantage of the hot reload module, so the sources are mounted inside the container.
Kharonus
reviewed
Jun 3, 2025
| @@ -128,7 +128,7 @@ run-backend: ## Start only the backend application and all needed services | |||
| run: ## start the wsgi (production) and development server | |||
| run: | |||
| @$(MAKE) run-backend | |||
| @$(COMPOSE) up --force-recreate -d frontend | |||
| @$(COMPOSE) up --force-recreate -d frontend-development | |||
There was a problem hiding this comment.
Great work, can you amend the build-frontend make target, too, so that it builds both services?
There was a problem hiding this comment.
Only the port 3000 is available, so starting both containers will cause problems.
AntoLC
approved these changes
Jun 3, 2025
| image: impress:frontend-development | ||
| volumes: | ||
| - ./src/frontend:/home/frontend |
There was a problem hiding this comment.
There is lot of side effects by keeping the node_modules sync, I think it is common pattern to exclude it:
Suggested change
| - ./src/frontend:/home/frontend | |
| - ./src/frontend:/home/frontend | |
| - /home/frontend/node_modules | |
| - /home/frontend/apps/impress/node_modules |
There was a problem hiding this comment.
Pull Request Overview
Adds a new Docker Compose service for frontend development to enable hot reload by mounting local sources, and updates Makefile targets to use that service.
- Introduces
frontend-developmentservice in docker-compose with build args, volume mount, and port mapping - Updates Makefile
runalias to start the dev service instead of production frontend, and adjustsrun-frontend-developmentto stop containers before launching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Expose production frontend image/ports and add frontend-development service with build, volume, ports |
| Makefile | Change run to bring up frontend-development and update run-frontend-development stop logic |
Comments suppressed due to low confidence (2)
docker-compose.yml:174
- The
imagekey forfrontend-developmentis indented with 6 spaces, but service-level keys should use 4 spaces. This misalignment can cause a YAML parse error.
image: impress:frontend-development
Makefile:319
- The
run-frontend-developmenttarget stops both services but never starts thefrontend-developmentcontainer. To leverage the new Compose service for hot reload, add@$(COMPOSE) up --force-recreate -d frontend-developmentbefore runningyarn dev.
cd $(PATH_FRONT_IMPRESS) && yarn dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want a serice in compose starting the frontend application in development mode. We want to take the advantage of the hot reload module, so the sources are mounted inside the container.
Proposal