add role navigation and semantic list to left panel nav #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
requested changes
Jul 28, 2025
| > | ||
| {defaultQueries.map((query) => { | ||
| const isActive = target === query.targetQuery; | ||
| <nav role="navigation" aria-label="Docs filters"> |
There was a problem hiding this comment.
Hello Thanks for the semantic update !
You can remove role="navigation", as it’s implicit on the nav element. It’s only necessary if you're using a non-semantic container like a div.
and Also, consider updating the aria-label something like "Document sections" would be more meaningful for screen reader users than "Docs filters".
Suggested change
| <nav role="navigation" aria-label="Docs filters"> | |
| <nav aria-label="Document sections"> |
| font-weight: ${isActive ? 700 : undefined}; | ||
| &:hover { | ||
| background-color: ${colorsTokens['greyscale-100']}; | ||
| } |
There was a problem hiding this comment.
There’s no visible focus outline, so it's hard to know where we are.
👉 You may need to explicitly add a :focus-visible style on the BoxButton to restore proper keyboard visibility.
Suggested change
| } | |
| } | |
| &:focus-visible { | |
| outline: 2px solid ${colorsTokens['primary-500']}; | |
| outline-offset: 2px; | |
| border-radius: ${spacingsTokens['3xs']}; | |
| } |
| > | ||
| {defaultQueries.map((query) => { | ||
| const isActive = target === query.targetQuery; | ||
| <nav role="navigation" aria-label="Docs filters"> |
There was a problem hiding this comment.
The visual layout seems slightly broken after this change probably some missing spacing or margin on the filter items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance accessibility: add role="navigation" and semantic list to left panel
Issue associée : 879