🚸(helm) improve helm chart #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
reviewed
Jun 5, 2025
src/helm/impress/Chart.yaml
Outdated
| type: application | ||
| name: docs | ||
| version: 3.3.0 | ||
| version: 3.3.1 |
Collaborator
There was a problem hiding this comment.
It follows the release version.
Suggested change
| version: 3.3.1 | |
| version: 3.3.0-beta.1 |
AntoLC
reviewed
Jun 5, 2025
| - | | ||
| while ! python manage.py check --database default > /dev/null 2>&1 | ||
| do | ||
| echo "Database not ready" |
Collaborator
There was a problem hiding this comment.
Same, maybe add a "sleep" ?
rouja
force-pushed
the
improve-helm-chart
branch
2 times, most recently
from
a12acd8 to
3e84a95
Compare
lunika
reviewed
Jun 10, 2025
Our Helm chart wasn't suitable for use with Helm alone because jobs remained after deployment. We chose to configure ttlSecondsAfterFinished to clean up jobs after a period of time.
lunika
force-pushed
the
improve-helm-chart
branch
from
3e84a95 to
a83902a
Compare
lunika
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Helm chart wasn't suitable for use with Helm alone because jobs remained after deployment. We chose to configure ttlSecondsAfterFinished to clean up jobs after a period of time.