Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 7, 2025

Purpose

EDIT & FINAL: Following a discussion with @rl-83, we replaced the horizontal scroll approach with an adjustable panel bar using react-resizable-panels.

This change improves usability by allowing users to resize the document tree panel within defined limits. It ensures better visibility of nested documents without using scrollbars and aligns with the implementation used in our shared UI Kit (where resizing is handled via the MainLayout, not inside the document tree component).

added e2e tests to cover this new resizable behavior too.

issue : 1180

ajustbar.mp4

Proposal

  • Add react-resizable-panels (v3.0.6) dependency
  • Implement PanelGroup with a horizontal resize handle in MainLayout
  • Persist panel size in localStorage
  • Set min width to 300px, max width to 450px (capped at 40% of viewport)
  • Keep mobile behavior unchanged (no resize handle)
  • Add e2e tests for resizable panel behavior

@Ovgodd Ovgodd requested a review from AntoLC October 7, 2025 09:05
@Ovgodd Ovgodd self-assigned this Oct 7, 2025
@Ovgodd Ovgodd added bug Something isn't working frontend triage multipages labels Oct 7, 2025
@Ovgodd Ovgodd force-pushed the fix/1180-make-horizontal-overflow-panel branch from 0abe61e to f0c1194 Compare October 7, 2025 09:06
@Ovgodd Ovgodd marked this pull request as ready for review October 7, 2025 09:06
@Ovgodd Ovgodd marked this pull request as draft October 8, 2025 08:44
@Ovgodd Ovgodd force-pushed the fix/1180-make-horizontal-overflow-panel branch 5 times, most recently from 3e294e9 to c255024 Compare October 13, 2025 12:30
@Ovgodd Ovgodd marked this pull request as ready for review October 13, 2025 12:31
@Ovgodd Ovgodd force-pushed the fix/1180-make-horizontal-overflow-panel branch from c255024 to 3406fee Compare October 13, 2025 12:31
Copy link

github-actions bot commented Oct 13, 2025

Size Change: +12 kB (+0.33%)

Total Size: 3.67 MB

Filename Size Change
apps/impress/out/_next/static/b30e7eeb/_buildManifest.js 0 B -883 B (removed) 🏆
apps/impress/out/_next/static/chunks/pages/404.js 1.9 kB +507 B (+36.4%) 🚨
apps/impress/out/_next/static/chunks/pages/docs.js 1.47 kB +514 B (+53.71%) 🆘
apps/impress/out/_next/static/chunks/pages/index.js 1.49 kB +515 B (+52.82%) 🆘
apps/impress/out/_next/static/chunks/pages/offline.js 6.61 kB +554 B (+9.14%) 🔍
apps/impress/out/_next/static/070394bf/_buildManifest.js 905 B +905 B (new file) 🆕
apps/impress/out/_next/static/chunks/7437.js 8.8 kB +8.8 kB (new file) 🆕

compressed-size-action

mainlayout and leftpanel updated with resizable panel saved in localstorage

Signed-off-by: Cyril <[email protected]>

✨(frontend) show full nested doc names with horizontal scroll support

horizontal overflow enabled and opacity used for sticky actions visibility

Signed-off-by: Cyril <[email protected]>

✨(frontend) show full nested doc names with horizontal scroll support

horizontal overflow enabled and opacity used for sticky actions visibility

Signed-off-by: Cyril <[email protected]>

✨(frontend) add resizable-panels lib also used in our shared ui kit

needed for adaptable ui consistent with our shared ui kit components

Signed-off-by: Cyril <[email protected]>
@Ovgodd Ovgodd force-pushed the fix/1180-make-horizontal-overflow-panel branch from 3406fee to f059014 Compare October 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant