Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noop location_link method #3999

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove noop location_link method #3999

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Feb 22, 2024

No description provided.

@cbeer
Copy link
Member

cbeer commented Feb 22, 2024

I'm not sure we're ready to remove this method. While we're no longer using it to link out to Lane's catalog, they're using the location detail discoveryDisplayUrl (e.g. https://lane.stanford.edu/view/bib/312369 / https://searchworks.stanford.edu/view/L312369) to drive very similar behavior and it seems likely to me we'll resume using this behavior in the not-too-distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants