Remove old courses from the cache #4061
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
filter-old-courses
branch
from
93bdfc9
to
da9926c
Compare
cbeer
reviewed
Mar 1, 2024
app/services/folio_client.rb
Outdated
| # So we'll post process instead. | ||
| get_json('/coursereserves/courses', params: { limit: 2_147_483_647 }) | ||
| .fetch('courses', []) | ||
| .filter { |course| Time.parse(course.dig('courseListingObject', 'termObject', 'startDate')).future? } # rubocop:disable Rails/TimeZone |
There was a problem hiding this comment.
Wouldn't this exclude the current term too (because it's start date is in the past)?
There was a problem hiding this comment.
Thanks, I will change it to endDate
Otherwise the cache will grow without bound
jcoyne
force-pushed
the
filter-old-courses
branch
from
da9926c
to
7b78242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the cache will grow without bound
Holding until sul-dlss/searchworks_traject_indexer#1376 is resolved.