[HOLD] Bump dependencies to latest versions #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
commented
Apr 17, 2025
Comment on lines
-8
to
-9
| gem 'byebug' | ||
| gem 'rspec_junit_formatter' # For CircleCI |
There was a problem hiding this comment.
I don't know why we need to declare dev/test dependencies in two places, so I moved this to the gemspec.
mjgiarlo
force-pushed
the
bump-dependencies
branch
from
d6a9eec to
11b35e8
Compare
mjgiarlo
commented
Apr 17, 2025
| @@ -35,15 +35,17 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'nokogiri' | |||
| # Match these version requirements to what committee wants, | |||
| # so that our client (non-committee) users have the same dependencies. | |||
| spec.add_dependency 'openapi_parser', '~> 1.0' | |||
| spec.add_dependency 'openapi_parser', '~> 2.0' | |||
There was a problem hiding this comment.
Pick up more recent releases of openapi_parser and committee. Any reason to be more conservative about this?
mjgiarlo
commented
Apr 17, 2025
| spec.add_dependency 'super_diff' | ||
| spec.add_dependency 'thor' | ||
| spec.add_dependency 'zeitwerk', '~> 2.1' | ||
|
|
||
| spec.add_development_dependency 'bundler', '~> 2.0' | ||
| spec.add_development_dependency 'committee' | ||
| spec.add_development_dependency 'debug' |
There was a problem hiding this comment.
Replace byebug with debug.
mjgiarlo
force-pushed
the
bump-dependencies
branch
from
11b35e8 to
fe21628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOLD until we are confident this is a safe move to make. Note that the DSA build below fails apparently because committee's error behavior has changed.
Why was this change made?
Why not?
How was this change tested?