-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update header component #95
Conversation
styles/header.css
Outdated
* an <li> because they would be counted as items in the list. Repositioning of | ||
* other elements during opening of the menu makes them jump around, so we also | ||
* have to disable animation of opening/closing the nav. */ | ||
.navbar hr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this occur?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<hr class="d-md-none text-white vw-100 my-0" /> |
<hr class="d-md-none text-white vw-100 my-0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot to digest at once. Is there any way to break it up into smaller pieces of work?
814f009
to
a13b573
Compare
Broke off the changes that add the new variants so that this PR is only the changes to the existing dark variants for easier review. |
a13b573
to
9ec3892
Compare
9ec3892
to
afb5d69
Compare
afb5d69
to
6f8e490
Compare
A preview of this branch is available at https://sul-dlss.github.io/component-library/preview-95. |
The opening of the mobile menu is kind of choppy |
It's supposed to just be immediate (no animation at all). Is that what you see? |
Yeah, currently there is animation: https://sul-dlss.github.io/component-library/header/ |
Right. This PR turns it off: component-library/styles/header.css Lines 62 to 67 in 6f8e490
|
This updates the designs to match the v.2 header component in Figma.
The templates were updated to make the content as close as possible to what's currently in Figma.
Closes #92