[SPIKE] Adds support for workflow database. #5388
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
Jun 18, 2025
config/database.yml
Outdated
| database: "<%= ENV.fetch('DATABASE_NAME', 'dor_services_development') %>" | ||
| workflow: | ||
| <<: *workflow_default | ||
| database: "<%= ENV.fetch('WORKFLOW_DATABASE_NAME', 'workflow_production') %>" |
There was a problem hiding this comment.
Do we want the default WF DB name to be the same (prod) value in all three envs?
There was a problem hiding this comment.
Nope. Fixing.
mjgiarlo
reviewed
Jun 18, 2025
config/deploy.rb
Outdated
| @@ -53,7 +53,7 @@ | |||
| # set :keep_releases, 5 | |||
|
|
|||
| set :linked_dirs, %w[log tmp/pids tmp/cache tmp/sockets vendor/bundle config/certs config/settings] | |||
| set :linked_files, %w[config/database.yml] | |||
| # set :linked_files, %w[config/database.yml] | |||
There was a problem hiding this comment.
Can you say more about this change?
There was a problem hiding this comment.
The database configs are going to be set from env variables, so we don't want to use the database.yml from puppet.
justinlittman
changed the title
justinlittman
force-pushed
the
wf_multi_db
branch
from
af0c007 to
58c2131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡