Log errors but do not raise SystemExit for encumbrances script #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
requested changes
Nov 11, 2024
jermnelson
approved these changes
Nov 11, 2024
|
I modified the fix_encumbrances script to print the "info" and "warning" statements to stdout (the log file) and the "errors" to both stdout and the logger. |
shelleydoljack
approved these changes
Nov 12, 2024
| @@ -723,9 +750,9 @@ async def unrelease_encumbrances_with_non_zero_amounts( | |||
| async def unrelease_open_orders_encumbrances_with_nonzero_amounts( | |||
| fiscal_year_id, open_orders_ids | |||
| ): | |||
| logger.info('Unreleasing open orders encumbrances with non-zero amounts...') | |||
| print('Unreleasing open orders encumbrances with non-zero amounts...') | |||
There was a problem hiding this comment.
Is this the one where we updated it to fix it even if it has zero amounts? I think we should fixup the warning message too.
There was a problem hiding this comment.
I think that was
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix_encumbrances dag will not email the log if there is an error that raises SystemExit(1). Log the errors and always complete the script.