Fixes counting of instances passed to trigger 979 dag runs #1436
+16
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g data that is list of lists." This reverts commit c6742fb.
jermnelson
approved these changes
Nov 14, 2024
jgreben
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1434
I realized that this trigger_digital_bookplate_979_task function works as it should, just that the logging was wrong. See the prod dag run for LINDER fund, where the mapped tasks are reported in the log for trigger_digital_bookplate_979_task__1 is
INFO - Total incoming instances 21. This PR fixes what was not necessary (reverts commit c6742fb) and adds the row length to total_instances to get accurate count.After this is merged and deployed, we need to re-run this failed dag run.