-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cbrelease 4.8.6 #101
base: cbrelease-4.8.6_hotfix
Are you sure you want to change the base?
Cbrelease 4.8.6 #101
Changes from 4 commits
7f73e9f
8dddde3
172949c
5e0ec68
3e2d2f9
84ba5fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't refactor the method readById at Dao level , it should provide all details needed. Based on need modify the response received at service level. |
dkttarento marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sendEmailNotificationMailForBatchDatesUpdate shld be Async , req cannot wait till all notifications sent to all the users of the batch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update request is handled by CourseBatchManagementActor, and mail is send by CourseBatchNotificationActor, this itself will be async call to CourseBatchNotificationActor this is flow i think correct me if i am wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for requested batchId there will be only one batch record , why we changed the signature to List ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaipradeepR , for single batchid , we can have multiple users enrolled in a batch(keyspace name =sunbird_courses) table name enrollment_batch_lookup.