Telemetry fixes #55
Open
Telemetry fixes #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik-tarento
suggested changes
Jun 20, 2023
course-mw/course-actors-common/src/main/java/org/sunbird/learner/constants/CourseJsonKey.java
Outdated
Show resolved
Hide resolved
Comment on lines
219
to
233
| public Map<String, Object> getBatchAttributes() { | ||
| return batchAttributes; | ||
| } | ||
|
|
||
| public void setBatchAttributes(Map<String, Object> batchAttributes) { | ||
| this.batchAttributes = batchAttributes; | ||
| } | ||
|
|
||
| public Integer getCurrentBatchSize() { | ||
| return currentBatchSize; | ||
| } | ||
|
|
||
| public void setCurrentBatchSize(Integer currentBatchSize) { | ||
| this.currentBatchSize = currentBatchSize; | ||
| } |
There was a problem hiding this comment.
this is poor design... you have batchAttriubtes then why you need currentBatchSize as additional attribute in the object??
the request body you can add the batchSize inside the batchAttributes -- so that it is easy in future to add more parameters...
...-actors/src/main/java/org/sunbird/learner/actors/coursebatch/CourseBatchManagementActor.java
Outdated
Show resolved
Hide resolved
...-actors/src/main/java/org/sunbird/learner/actors/coursebatch/CourseBatchManagementActor.java
Outdated
Show resolved
Hide resolved
...-actors/src/main/java/org/sunbird/learner/actors/coursebatch/CourseBatchManagementActor.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: