Telemetry fixes #55

juhiagl8 · 2023-06-19T14:07:45Z

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Ran Test A
Ran Test B

Test Configuration:

Software versions: Java-11, play2-2.7.2, scala-2.11, redis-5.0.3
Hardware versions: 2 CPU / 4GB RAM

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

course-mw/course-actors-common/src/main/java/org/sunbird/learner/constants/CourseJsonKey.java

karthik-tarento · 2023-06-20T05:39:29Z

course-mw/course-actors-common/src/main/java/org/sunbird/models/course/batch/CourseBatch.java

+  public Map<String, Object> getBatchAttributes() {
+    return batchAttributes;
+  }
+
+  public void setBatchAttributes(Map<String, Object> batchAttributes) {
+    this.batchAttributes = batchAttributes;
+  }
+
+  public Integer getCurrentBatchSize() {
+    return currentBatchSize;
+  }
+
+  public void setCurrentBatchSize(Integer currentBatchSize) {
+    this.currentBatchSize = currentBatchSize;
+  }


this is poor design... you have batchAttriubtes then why you need currentBatchSize as additional attribute in the object??
the request body you can add the batchSize inside the batchAttributes -- so that it is easy in future to add more parameters...