Skip to content

Update fingerprints.py #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master-new
Choose a base branch
from

Conversation

lucentheart
Copy link

@lucentheart lucentheart commented Jul 13, 2025

Added b'8S102-T90-A060\x00\x00' for Ecu.fwdCamera in CAR.HONDA_PILOT_4G.

Validation

Summary by Sourcery

Enhancements:

  • Include b'8S102-T90-A060\x00\x00' in the Ecu.fwdCamera fingerprint list for CAR.HONDA_PILOT_4G

Added b'8S102-T90-A060\x00\x00' for Ecu.fwdCamera in CAR.HONDA_PILOT_4G.
Copy link

sourcery-ai bot commented Jul 13, 2025

Reviewer's Guide

Extend the HONDA_PILOT_4G ECU fingerprint mapping by adding a new forward camera ID to recognize additional hardware versions.

File-Level Changes

Change Details Files
Add new forward camera fingerprint for HONDA_PILOT_4G
  • Insert b'8S102-T90-A060\x00\x00' into the Ecu.fwdCamera fingerprint list
opendbc/car/honda/fingerprints.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant