Tesla mads fixes #32
Open
Tesla mads fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for sunnypilot/sunnypilot#392
This is a prereq to sending a direct ACC cancel command via das_control even when using stock TACC, eliminating the need to inject fake right-stalk presses to cancel (which causes annoying alerts due to race conditions with the real stalk signal)
This pass-through is necessary to allow sending only an ACC cancel command even when not normally passing long control messages.
Additionally this changes the MADS enablement to activeTouchPoints == 3 (3-finger tap), as overloading the stalk with acc and mads was too confusing and buggy.
Safety considerations: