Fixed issue #254 - auto "fireuping" sup-config, if there are no any configured sources

[tradzik]

Added automatic fire-uping "sup-config" if there are no any configured sources.

[eMBee]

test how it works with:

  - no .sup dir
  - a previous config.yml but no sources.yml
  - both existing, but perhaps sources empty.

[tradzik]

Ok, @eMBee . I will make these tests. What should I do after that? Is there anything wrong?

[eMBee]

report on how each test went and, see if the script was started in every case.
also check maybe if config.yaml was changed after running the script.

if the tests pass, then there is nothing to do, otherwise, look into what needs to be fixed to make that test work.

[tradzik]

Thank you for your answer. I will finish tests ASAP and give results there

[tradzik]

First test report: script started without any problem

[tradzik]

Second test: mistakes found. Runtime error. Improving

[tradzik]

Now, after my changes, all tests work

[gauteh]

make sure recovering from ncurses setup work. starting and stopping
external programs from sup does not work without a bit of care.

On Tue, Dec 30, 2014 at 11:16 AM, Tymon Radzik [email protected]
wrote:

Now, after my changes, all tests work

—
Reply to this email directly or view it on GitHub
#358 (comment).

[gauteh]

Why are you doing this? Make sure you understand all the implications of the changes you are doing as well as testing it. Changing this line is not something you do without careful thought and a good overview of how sup works.

[tradzik]

I have fixed that as in disscussion. Now everything should be ok. Please also take a look on #359

[eMBee]

this works, but i wonder if we need do consider more cases.

right now, if i go through config, but explicitly do not add sources, it will ask me again every time until i have at least one source.
is it conceivable to use sup without sources? for sending only maybe? or do i need to add sent as a source? shouldn't that be in the sources by default?

i think that once config has been called, it should not be called again unless explicity invoked.
this could be solved like so: config is called, it sets a flag in the config about being called. sup starts, it checks the flag. if there, it moves on. if missing, sup calls config.

[eMBee]

as mentioned before: in commit messages: don't write "Added eMBee's suggestion" but explain what the actual change/suggestion is

[eMBee]

to sup devs: is a file to mark configured state ok? or is there a better way to mark that? some variable that can be saved?

[gauteh]

What about just checking if it matches default config and whether there are any sources, then ask the user whether he wants to launch sup-config (I can't think of any use case where the user would want to work without any sources, any previously indexed messages would be useless since they rely on the source to be able to open them). If there is, then there could be a config option that says something like 'do-not-ask-to-start-sup-config-again'.

[gauteh]

Is this not done twice now (in case of configured)?