chore: initial pretty printer #546
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
force-pushed
the
feat/pretty-print-try-2
branch
from
4c5072f to
c7d27e6
Compare
Open
Key fixes in this session: - CREATE TYPE ... AS RANGE: Added line breaking before parameters - CREATE TABLE OF type: Handle column overrides with WITH OPTIONS syntax - CREATE STATISTICS: Added SoftOrSpace before ON clause - RangeVar alias: Changed to SoftOrSpace for line breaking - JsonFuncExpr: Fixed enum values (1=EXISTS, 2=QUERY, 3=VALUE) - JSON expressions: Added location normalization for JsonParseExpr, JsonFuncExpr, JsonScalarExpr, JsonSerializeExpr - RangeFunction: Added coldeflist emission for record functions - SYSTEM_USER and similar: Emit without parentheses and uppercase - AIndirection normalization: Added for JoinExpr, AExpr, RangeSubselect - FOREIGN KEY constraint: Added line breaking before column list - JsonSerializeExpr: Fixed double RETURNING clause emission - Line length check: Allow lines with unbreakable long identifiers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix GRANT statement line breaking - Fix CLUSTER stmt USING line breaking - Fix REFRESH MATERIALIZED VIEW line breaking - Fix ParamRef overflow (render as u32) - Fix ResTarget AS line breaking - Fix function call soft line breaks after/before parens - Fix CREATE SEQUENCE options line breaking - Fix ALTER TABLE SET EXPRESSION line breaking - Fix CREATE FUNCTION name line breaking - Add INCLUDE clause emission for UNIQUE, PRIMARY KEY, EXCLUDE constraints - Fix CREATE TRANSFORM line breaking - Fix DROP SUBSCRIPTION CASCADE/RESTRICT values - Add NullTest and BoolExpr precedence info for parentheses - Add comparison operator non-associativity handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Major fixes in this commit: - Fix RangeFunction alias + coldeflist syntax (func(...) AS alias (cols)) - Fix CREATE ROLE and RoleSpec identifier quoting for special chars - Fix ALTER GROUP ADD/DROP USER syntax (was emitting wrong keywords) - Fix CREATE FUNCTION SET option double emission - Fix ALTER TYPE ADD ATTRIBUTE syntax (was emitting ADD COLUMN) - Fix GRANT IN SCHEMA missing space before schema name - Fix NORMALIZE function handling: - Detect built-in vs user-defined based on second argument - Quote user-defined normalize() to avoid conflict with built-in - Add function name case normalization in tests - Add NORMALIZE second argument normalization (ColumnRef <-> AConst) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
…izations - ALTER SUBSCRIPTION: fix SET vs WITH options, ENABLE/DISABLE detection - Common table expressions: add line breaks for readability - Drop statement: add soft line break before objects - Set operations: fix parenthesization for ORDER BY/LIMIT/OFFSET/WITH - Normalizations: add JoinExpr ON TRUE -> NULL, handle nested structures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
psteinroe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todos: