Skip to content

Fix exception on non-session hash parameters and only consume used parameters #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2025

Conversation

jan-tennert
Copy link
Collaborator

What kind of change does this PR introduce?

Bug fix (closes #910)

What is the current behavior?

Exception on non-session hash parameters and all other hash parameters get removed

What is the new behavior?

This has been fixed.

@github-actions github-actions bot added the tests label Apr 26, 2025
@jan-tennert jan-tennert merged commit 926f9a0 into master Apr 26, 2025
13 checks passed
@jan-tennert jan-tennert deleted the js-fragments branch April 26, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Arbitrary hash parameters cause hard to catch exception (e.g. expired OTP link)
1 participant