Skip to content

fix(supabase): revert client platform and runtime detection headers#2067

Merged
grdsdev merged 1 commit intomasterfrom
fix/revert-client-headers
Jan 27, 2026
Merged

fix(supabase): revert client platform and runtime detection headers#2067
grdsdev merged 1 commit intomasterfrom
fix/revert-client-headers

Conversation

@grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jan 27, 2026

Summary

Reverts PR #2046 which added client platform and runtime detection headers.

Changes

This PR reverts the following changes from #2046:

  • Removes X-Supabase-Client-Platform header
  • Removes X-Supabase-Client-Platform-Version header
  • Removes X-Supabase-Client-Runtime header
  • Removes X-Supabase-Client-Runtime-Version header
  • Restores DEFAULT_HEADERS to simple format with only X-Client-Info header
  • Removes associated helper functions and tests (296 lines removed)

Testing

  • All unit tests pass (8/8 test suites)
  • Critical test/unit/constants.test.ts passes
  • Changes cleanly revert to previous implementation

Type of Change

  • Bug fix (fix)
  • Revert

Checklist

  • Code formatted
  • Tests passing
  • Builds passing

Reverts #2046

Summary by CodeRabbit

  • Refactor
    • Simplified client information header generation by removing platform and runtime detection logic.

✏️ Tip: You can customize this high-level summary in your review settings.

@grdsdev grdsdev requested a review from a team as a code owner January 27, 2026 21:50
@github-actions github-actions bot added the supabase-js Related to the supabase-js library. label Jan 27, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

This PR removes runtime platform and runtime-version detection logic from the supabase-js library. The DEFAULT_HEADERS constant is now statically defined with only the X-Client-Info header instead of being dynamically built through multiple detection functions. Associated tests have been correspondingly simplified.

Changes

Cohort / File(s) Change Summary
Header Simplification
packages/core/supabase-js/src/lib/constants.ts, packages/core/supabase-js/test/unit/constants.test.ts
Removed runtime platform and runtime-version detection functions; replaced dynamic header building (buildHeaders() call) with static X-Client-Info object literal. Simplified test coverage from comprehensive platform/runtime detection assertions to basic header structure validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • alaister
  • filipecabaco
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting client platform and runtime detection headers. It directly summarizes the primary purpose of the PR (a revert of PR #2046) and is concise and descriptive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Coverage Status

coverage: 81.864% (+0.2%) from 81.655%
when pulling 53e2348 on fix/revert-client-headers
into f38a179 on master.

@grdsdev grdsdev enabled auto-merge (squash) January 27, 2026 22:04
@grdsdev grdsdev merged commit 91b36d7 into master Jan 27, 2026
23 checks passed
@grdsdev grdsdev deleted the fix/revert-client-headers branch January 27, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

supabase-js Related to the supabase-js library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants