-
-
Notifications
You must be signed in to change notification settings - Fork 169
ci: optimize CI workflow with path filtering #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7314484
to
f581a6a
Compare
…ove problematic conditional
f581a6a
to
f8ec4f7
Compare
Add intelligent path filtering to CI workflow to only run when files that could impact the build are changed. This includes source code, tests, examples, package configuration, build files, and CI configuration itself. This optimization reduces unnecessary CI runs for documentation changes, README updates, or other non-code modifications while ensuring all impactful changes trigger the build. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Pull Request Test Coverage Report for Build 16828429714Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with small nitpicks.
- '*.swift' | ||
- 'Package.swift' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't *.swift
cover Package.swift
? Do we need to be redundant here?
- 'Makefile' | ||
- '*.xcodeproj/**' | ||
- '*.xcworkspace/**' | ||
- '.swiftpm/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about package.json
? I know it is for tooling but we might want to run CI on changes for it.
Thanks for the approval @o-santi it automatically merged, I'll include those feedbacks in the next PR. |
Summary
Changes
The CI workflow now only runs when these file patterns change:
Sources/**
,Tests/**
,Examples/**
,*.swift
Package.swift
,Package.resolved
,.swiftpm/**
Makefile
,*.xcodeproj/**
,*.xcworkspace/**
.github/workflows/ci.yml
Test plan
🤖 Generated with Claude Code