Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to some machine error message text #2900

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

andie787
Copy link
Contributor

@andie787 andie787 commented Oct 12, 2023

Change Summary

What and Why:

Error message example: Error: timeout reached waiting for machine to started , where started is the machine state. Updated for slightly better readability to timed out waiting for machine to reach started state:.

Plus a few other changes for consistency.

How:
edited error messages

Related to:
n/a


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@catflydotio
Copy link
Contributor

The word "reach" is in there twice...

@andie787
Copy link
Contributor Author

andie787 commented Oct 12, 2023

☺️
good point!
a) "timeout reached waiting for machine to be in %s state: %w"
b) "timed out waiting for machine to reach %s state: %w"
vote now @catflydotio !

@catflydotio
Copy link
Contributor

I like (b) :)

@andie787 andie787 merged commit 0821f29 into master Oct 12, 2023
35 of 37 checks passed
@andie787 andie787 deleted the update-timeout-error branch October 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants