Make sure to wait before restarting the remote builder #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the remote builder is in the 'created' or 'migrating' state, then we won't be able to restart it. By making sure to wait for one of those two states, we can avoid errors like: `failed to fetch an image or build from source: failed to restart VM asfijsdoif: failed_precondition: unable to restart machine, not currently started or stopped`
channels are better than that disgusting mutex garbage i was doing
silly testing bug
Basically, if the builder is in the 'created' state for example, and we transition into 'started', there's no reason to start it.
billyb2
force-pushed
the
wait_before_start_builder
branch
from
37f42e5 to
4d205c9
Compare
that's dumb. instead we should just return a standard WaitTimeoutErr if we can't reach any state.
switch statements are the future Co-authored-by: JP [email protected]
billyb2
force-pushed
the
wait_before_start_builder
branch
from
c998198 to
ce89c34
Compare
billyb2
commented
Jul 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
If the remote builder is in the 'created' or 'migrating' state, then we won't be able to restart it. By making sure to wait for one of those two states, we can avoid errors like:
failed to fetch an image or build from source: failed to restart VM asfijsdoif: failed_precondition: unable to restart machine, not currently started or stoppedHow:
make sure that the builder machine is either in the started or stopped state before calling the 'restart' API
Related to:
Documentation