Skip to content

Support config argument on apps restart #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grgar
Copy link
Contributor

@grgar grgar commented Apr 8, 2025

 Restart an application. Perform a rolling restart against all running Machines.
 
 Usage:
-  fly apps restart <app name> [flags]
+  fly apps restart [name] [flags]
 
 Flags:
+  -a, --app string           Application name
+  -c, --config string        Path to application configuration file
       --force-stop           Performs a force stop against the target Machine
   -h, --help                 help for restart
       --skip-health-checks   Restarts app without waiting for health checks

@dangra
Copy link
Member

dangra commented Apr 8, 2025

what for?

@grgar
Copy link
Contributor Author

grgar commented Apr 8, 2025

Seems odd some commands support it and some don't. I regularly use -c with other commands. While not personally on this one, that there is a bug report means someone else does so I thought I'd take a look.

edit: NameFromContext is already called if one is not specified on the command line, so update the usage to clarify that it is optional and support the normal app flag.

NameFromContext is already called if one is not specified on the command line, so update the usage to clarify that it is optional and support the normal app flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fly -c <config.toml> apps restart doesn't pick up app name
2 participants