-
Notifications
You must be signed in to change notification settings - Fork 951
fix #350: GitHub Icon not visible #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update includes two changes: a documentation update in a CSS file and a minor modification to an SVG icon component. The Tailwind CSS version comment in the global stylesheet was updated to reflect a new version. Additionally, the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/app/components/icons/IntegrationIcons.tsx (1)
13-13
: Suggest consistent theming across all icons
TheNotionIcon
still uses a hard‑codedfill="#FFF"
. For consistent theming (and dark‑mode support), consider switching it (and similarly theTwitterIcon
/GoogleCalendarIcon
) to usecurrentColor
or accept acolor
prop.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/extension/public/globals.css
(1 hunks)apps/web/app/components/icons/IntegrationIcons.tsx
(1 hunks)
🔇 Additional comments (2)
apps/extension/public/globals.css (1)
110-110
: Approve version comment update
The Tailwind CSS version comment has been bumped from v3.4.15 to v3.4.17—this documentation change correctly reflects the upgrade.apps/web/app/components/icons/IntegrationIcons.tsx (1)
47-47
: Approve dynamic fill for GitHub icon
Changing the<svg>
fill
tocurrentColor
is the right fix to allow the icon to inherit its surrounding text color, resolving the visibility issue.
fixes: #350
before:

now:
