Migrate various APIs to fs::path #7151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's different on Windows; a native string is wide. So on Windows this would just be an infinite recursion, rather than what we actually want.
baconpaul
reviewed
Aug 9, 2023
Collaborator
baconpaul
left a comment
baconpaul
left a comment
There was a problem hiding this comment.
Looks good! One copy we don’t need
| } | ||
|
|
||
| void FxUserPreset::saveFxIn(SurgeStorage *storage, FxStorage *fx, const std::string &s) | ||
| void FxUserPreset::saveFxIn(SurgeStorage *storage, FxStorage *fx, fs::path sp) |
Collaborator
There was a problem hiding this comment.
Should this be const fs::path &
| bool readFromXMLSnapshot(Preset &p, TiXmlElement *); | ||
|
|
||
| void saveFxIn(SurgeStorage *s, FxStorage *fxdata, const std::string &fn); | ||
| void saveFxIn(SurgeStorage *s, FxStorage *fxdata, fs::path sp); |
Collaborator
There was a problem hiding this comment.
Const & again to avoid thencopy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE this yet. This pull request will end up with several more commits as part of it. I'm opening it early to test Windows CI.