Add support for RecordId (#372) #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kearfy Work so nice we do it twice. This time I actually got the biome scan to run locally 😄 |
kearfy
reviewed
Nov 13, 2024
Co-authored-by: Micha de Vries <[email protected]>
Contributor
Author
|
I'm going to be honest, I should have looked at that! 😆 |
kearfy
approved these changes
Nov 13, 2024
Member
|
That's alright haha! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
Having support for initializing StringRecordId in cases where the input may already be a RecordId or a StringRecordId and not just a plain string.
What does this change do?
Adds support for initialing a
StringRecordIdobject with a providedRecordIdobject.What is your testing strategy?
This class doesn't have any tests yet, and my changes were trivial.
Is this related to any issues?
#372 #373
Have you read the Contributing Guidelines?